Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-9132

Bad copy using <framework> tag.

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Not A Problem
    • 5.0.0
    • None
    • cordova-lib
    • Windows 7, git-scm.

    Description

      (I have been reading that Intel has a bug report ready, but I can't wait and I don't know if they forgot about it or possibly died.)

      My plugin uses the Google downloader_library and play_licensing_library. The project.properties file links to the downloader_library, which itself links to the play_licensing library. So here's the deal – Cordova 5 blew up my plugin in some way: https://github.com/agamemnus/cordova-plugin-xapkreader/issues/22

      The purported fix suggested by Intel was to use Gradle – add a build-extras.gradle file to one spot, and add two framework tags (for the two libraries I am using) to plugin.xml:

      <framework src="android-sdk/extras/google/play_apk_expansion/downloader_library" custom="false"/>
      <framework src="android-sdk/extras/google/play_licensing/library" custom="false" />

      ... then in play_apk_expansion/downloader_library, I have a file like this:
      dependencies {
      debugCompile project(path: '..:..:play_licensing:library',configuration: "debug")
      releaseCompile project(path: '..:..:play_licensing:library',configuration: "release")
      }

      Okay, cool, but there are two problems, one of which is DEFINITELY a Cordova bug:

      1) Using custom="false" gives me lots of problems. I get errors that say that the project isn't a gradle library and none of the linking works. How do I fix this? I don't want to use custom="true".

      2) Using custom="true" doesn't give me those problems, but the files are incorrectly copied to my /platforms/android directory.

      They are copied to:
      /platforms/android/com.flyingsoftgames.xapkreader/free-downloader_library
      /platforms/android/com.flyingsoftgames.xapkreader/free-library

      There seem to be two bugs here:
      A) Only the last directory is added. ("downloader_library" and "library").
      B) The last part of my PROJECTNAME is prefixed. This is NON-IDEAL (to put it lightly) for a plugin!!! (my project name has spaces, so the code decided to use the last word following a space... otherwise it uses the whole project name).

      Finally, I'm unable to do relative pathing. I had to do this in build-extras.gradle:
      ':com.flyingsoftgames.xapkreader:play_licensing:library'
      ...instead of this:
      '..:..:play_licensing:library'

      Attachments

        Activity

          People

            Unassigned Unassigned
            agamemnus Michael Romanovsky
            Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: