Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-8204

Gradle lint task exclusion broken on multi-apk builds

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      See https://github.com/apache/cordova-android/pull/138

      The logic in build.js that excludes lint tasks expects that the environment variable BUILD_MULTIPLE_APKS is set, but the actual build logic in gradle is defined by the variable `ext.multiarch`. When the two do not agree, then tasks which do not exist are excluded by name, which breaks the build.

      Solving this for now by removing the lint-exclusions from build.js. Eventually, if we decide we want them back, we can put that logic into build.gradle where it belongs.

      (The exclusions were implemented originally as a compilation speedup, not for correctness)

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                iclelland Ian Clelland
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: