[CB-7683] Android strings aren't added in upgrade process to 3.6.3

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: 3.6.3
• Fix Version/s: cordova-android-7.0.0
• Component/s: cordova-android, cordova-cli
• Labels: android-next
• Environment: {Xubuntu 13.10 x86_64} {node -v = v0.10.25} {npm -v = 2.0.2} {cordova -v = 3.6.3-0.2.13}
• Assignee: Unassigned
• Reporter: Frederico Costa Galvão
• Created: 01/Oct/14 18:37
• Updated: 23/Aug/18 06:46
• Resolved: 17/Jul/17 21:01

Description

The new strings added to ./platforms/android/res/values/strings.xml exist correctly on a newly created project, but don't in an upgraded project.

After upgrading my project from 3.5.0 to 3.6.3:

<string name="app_name">Bacon</string>

Expected:

<string name="app_name">Bacon</string>
<string name="launcher_name">@string/app_name</string>
<string name="activity_name">@string/launcher_name</string>

Also, in AndroidManifest.xml I expected

<activity android:label="@string/app_name"></actitivy>
<intent-filter></intent-filter>

to become the following (it didn't), after the upgrade:

<activity android:label="@string/activity_name"></activity>
<intent-filter android:label="@string/launcher_name"></intent-filter>

I don't quite know how or whether the project actually needs those strings or if they can infer them from the app_name string somewhere else, but it's nonetheless a bug, considering the upgrade process should take a project up to par with a newly created one.