Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-7043 iOS 8 Support
  3. CB-7596

[iOS 8] CDV_IsIPhone5() Macro needs to be updated because screen size is now orientation dependent

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.7.0
    • Component/s: iOS
    • Labels:
      None

      Description

      UIScreen is now orientation dependent in iOS 8:
      http://stackoverflow.com/questions/24150359/is-uiscreen-mainscreen-bounds-size-becoming-orientation-dependent-in-ios8

      If phone is 320x480 (w x h) portrait
      in iOS 7, the (w x h) in landscape is 320x480.
      Now in iOS 8, the (w x h) in landscape is 480x320

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user shazron commented on the pull request:

        https://github.com/apache/cordova-ios/pull/105#issuecomment-56101072

        Ouch, yeah this resulted in a bug for the statusbar plugin as well for landscape (fixed) :/
        Filed https://issues.apache.org/jira/browse/CB-7596

        Show
        githubbot ASF GitHub Bot added a comment - Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/105#issuecomment-56101072 Ouch, yeah this resulted in a bug for the statusbar plugin as well for landscape (fixed) :/ Filed https://issues.apache.org/jira/browse/CB-7596
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit b06ca8db4288f47e99f32294080106884e236d47 in cordova-ios's branch refs/heads/master from Clafou
        [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=b06ca8d ]

        CB-7596 - [iOS 8] CDV_IsIPhone5() Macro needs to be updated because screen size is now orientation dependent

        iOS8 introduces a change to screen orientation, making [UIScreen
        bounds] orientation-dependent. Testing for the iPhone5 screen
        resolution now needs to account for landscape (568x320) in addition to
        portrait (320x568).

        Details at
        http://stackoverflow.com/questions/24150359/is-uiscreen-mainscreen-bound
        s-size-becoming-orientation-dependent-in-ios8

        Signed-off-by: Shazron Abdullah <shazron@apache.org>

        Show
        jira-bot ASF subversion and git services added a comment - Commit b06ca8db4288f47e99f32294080106884e236d47 in cordova-ios's branch refs/heads/master from Clafou [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=b06ca8d ] CB-7596 - [iOS 8] CDV_IsIPhone5() Macro needs to be updated because screen size is now orientation dependent iOS8 introduces a change to screen orientation, making [UIScreen bounds] orientation-dependent. Testing for the iPhone5 screen resolution now needs to account for landscape (568x320) in addition to portrait (320x568). Details at http://stackoverflow.com/questions/24150359/is-uiscreen-mainscreen-bound s-size-becoming-orientation-dependent-in-ios8 Signed-off-by: Shazron Abdullah <shazron@apache.org>

          People

          • Assignee:
            shazron Shazron Abdullah
            Reporter:
            shazron Shazron Abdullah
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development