Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-7437

xhr readystate event passed bad event on some platforms

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: cordova-weinre
    • Labels:
      None

      Description

      description at https://github.com/apache/cordova-weinre/pull/8

      readystate change event bound in the _xhr() function in weinre.web/modules/weinre/common/WebSocketXhr.coffee

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user pmuellr commented on the pull request:

        https://github.com/apache/cordova-weinre/pull/8#issuecomment-53969191

        I've opened a bug for this:

        https://issues.apache.org/jira/browse/CB-7437

        I've got a slightly different patch, here:

        https://github.com/apache/cordova-weinre/blob/CB-7437/weinre.web/modules/weinre/common/WebSocketXhr.coffee#L204-L215

        Seems like it works to me, and doesn't require fn.bind().

        I'll merge in a few days, let me know if you have any issues with it.

        Show
        githubbot ASF GitHub Bot added a comment - Github user pmuellr commented on the pull request: https://github.com/apache/cordova-weinre/pull/8#issuecomment-53969191 I've opened a bug for this: https://issues.apache.org/jira/browse/CB-7437 I've got a slightly different patch, here: https://github.com/apache/cordova-weinre/blob/CB-7437/weinre.web/modules/weinre/common/WebSocketXhr.coffee#L204-L215 Seems like it works to me, and doesn't require fn.bind(). I'll merge in a few days, let me know if you have any issues with it.
        Show
        pmuellr Patrick Mueller added a comment - commit here: https://github.com/apache/cordova-weinre/commit/f6c24acb6c897de9ab2c68af41e92d8c54b5717c
        Hide
        pmuellr Patrick Mueller added a comment -

        fixed in commit: 34d2980aea58ddc0d62ddb3924b6c649aca03f4c

        published in release: 2.0.0-pre-HZO3BMNG (available at npm)

        Show
        pmuellr Patrick Mueller added a comment - fixed in commit: 34d2980aea58ddc0d62ddb3924b6c649aca03f4c https://git-wip-us.apache.org/repos/asf?p=cordova-weinre.git;a=commit;h=34d2980aea58ddc0d62ddb3924b6c649aca03f4c published in release: 2.0.0-pre-HZO3BMNG (available at npm)

          People

          • Assignee:
            pmuellr Patrick Mueller
            Reporter:
            pmuellr Patrick Mueller
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development