Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-7355

[CLI] removing unit tests which depend on external libraries

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: cordova-cli
    • Labels:
      None

      Description

      The cordova-cli has vestigial unit tests which now trigger on external dependencies (example below)

      These should be removed from the cli, and migrated to the appropriate lib if necessary.

      -        it("will NOT allow copy-from starting with 'http'", function () {
      -            var threwAnException = false;
      -            try {
      -                cli(["node", "cordova", "create", "a", "b" , "c", "--copy-from", "http://www.somesite.com"]);
      -            }
      -            catch(e) {
      -                threwAnException = true;
      -            }
      -            expect(cordova_lib.CordovaError).toHaveBeenCalledWith('Only local paths for custom www assets are supported.');
      -            expect(threwAnException).toBe(true);
      -        });
      -
      -        it("will allow link-to with ':' char", function () {
      

      in the example above, the behaviour is not implemented within the cordova cli

        Attachments

          Activity

            People

            • Assignee:
              lorin.beer Lorin Beer
              Reporter:
              lorin.beer Lorin Beer
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: