[CB-6890] Android plugins which use pluginManager fields break on 4.0.x branch

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.0
• Component/s: cordova-android, cordova-plugin-file, cordova-plugin-file-transfer (DEPRECATED), cordova-plugin-media-capture
• Assignee: Ian Clelland
• Reporter: Ian Clelland
• Created: 06/Jun/14 18:26
• Updated: 23/Aug/18 07:18
• Resolved: 06/Jun/14 19:04

Description

The field CordovaWebView.pluginManager was changed from a public field to a getter, getPluginManager(), for Cordova-Android v4.0.0. (to support pluggable webviews)

This means that code in plugins like this:

PluginManager pm = webView.pluginManager;

will break. However, the replacement code,

PluginManager pm = webView.getPluginManager();

will break on existing 3.x versions of Cordova.

The solution is to use reflection in the plugin to determine whether the method or the field is available, and to use the appropriate access method to get the plugin manager. This code works in both old and new versions of Cordova:

Class webViewClass = webView.getClass();
PluginManager pm = null;
try {
    Method gpm = webViewClass.getMethod("getPluginManager");
    pm = (PluginManager) gpm.invoke(webView);
} catch (NoSuchMethodException e) {
} catch (IllegalAccessException e) {
} catch (InvocationTargetException e) {
}
if (pm == null) {
    try {
        Field pmf = webViewClass.getField("pluginManager");
        pm = (PluginManager)pmf.get(webView);
    } catch (NoSuchFieldException e) {
    } catch (IllegalAccessException e) {
    }
}