Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-6147

Enable CLI and Plugman with npm shrinkwrap

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • Master
    • Master
    • None

    Description

      I think the npm modules cordova and plugman should be enable and publish with shrinkwrap.

      It doesn't mean that cordova-cli/plugman locks down dependency tree for ever, they can be updated as needed at any time a new version if publish to npm.

      More info here:
      https://www.npmjs.org/doc/cli/npm-shrinkwrap.html
      http://blog.nodejs.org/2012/02/27/managing-node-js-dependencies-with-shrinkwrap

      This provides multiple benefits:

      • Everyone testing cordova rc test the same code not just the cordova module, but all its dependencies
      • All users that npm install cordova or plugman get the same code including all dependencies
      • Easier to recreate an user environment, if user reports that is having problems with cordova@3.4.0-0.1.0 then another cordova contributor or committer wil be sure 100% that is running the same code as the user.
      • Avoids "it works on my system and not yours" without shrinkwrap it depends when an user installs cordova or plugman, and if any dependencies inside the whole dependency tree changes a version
      • Could be use to better clarify ALL dependencies including the versions that cordova/plugman was tested, so if a downstream distribution or end user wants to know what is a full list of dependencies to get cordova-cli and plugman working they can take a look at shrinkwrap.json
      • If a downstream distribution wants to redistribute cordova-cli and plugman, then it has higher confident of what dependencies where use at time of testing and releasing a specific version of cordov-cli/plugman, and if it wants to distribute cordova-cli/plugman including its dependencies it's easier to distribute only the versions that where use at time of testing/release.

      Attachments

        There are no Sub-Tasks for this issue.

        Activity

          People

            csantana Carlos Santana
            csantana Carlos Santana
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: