Apache Cordova
  1. Apache Cordova
  2. CB-610

Capture.bundle missing microphone image resources for retina iPad results in mis-drawn recording interface

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.0
    • Fix Version/s: 1.8.0
    • Component/s: iOS
    • Labels:
      None
    • Environment:

      Mac OS X 10.7.3 / Xcode 4.3 / iOS 5.1 / PhoneGap 1.7.0RC1

      Description

      the Capture.bundle that is added automatically to new projects via the project template has image resources for iPhone, Retina iPhone and iPad but not Retina iPad. as a result, when one brings up the default recording interface, it is not drawn correctly and is a little confusing.

        Activity

        Hide
        Jean-Pierre added a comment -

        what the default record interface looks like on a Retina iPad

        Show
        Jean-Pierre added a comment - what the default record interface looks like on a Retina iPad
        Hide
        Randy McMillan added a comment -

        The images need to be overhauled to ensure correct image resolution.

        https://github.com/apache/incubator-cordova-ios/pull/15

        Show
        Randy McMillan added a comment - The images need to be overhauled to ensure correct image resolution. https://github.com/apache/incubator-cordova-ios/pull/15
        Hide
        Shazron Abdullah added a comment -

        Randy I don't believe you have the source .PSDs to generate the right images (from your pull request), I'm pinging our design guys to get them.

        Show
        Shazron Abdullah added a comment - Randy I don't believe you have the source .PSDs to generate the right images (from your pull request), I'm pinging our design guys to get them.
        Hide
        Randy McMillan added a comment - - edited

        That artwork thing again...
        https://issues.apache.org/jira/browse/CB-469

        anyway...

        The code and image names should be refactored to reflect the naming convention* established by Xcode.

        Example:

        Image-Name~ipad.png
        Image-Name@2x~ipad.png

        but I didn't want to make any major changes in my commit.

        *take out underscores in the image names as well?

        Show
        Randy McMillan added a comment - - edited That artwork thing again... https://issues.apache.org/jira/browse/CB-469 anyway... The code and image names should be refactored to reflect the naming convention* established by Xcode. Example: Image-Name~ipad.png Image-Name@2x~ipad.png but I didn't want to make any major changes in my commit. *take out underscores in the image names as well?
        Show
        Shazron Abdullah added a comment - Fix commit: http://git-wip-us.apache.org/repos/asf/incubator-cordova-ios/commit/96533565
        Hide
        Jean-Pierre added a comment -

        for those of you following along at home - you can apply the fix to your project, you don't need to wait for the next build of Cordova. just copy the new image resources that Shazron added in the above commit, directly to your Capture.bundle and you are good to go.

        thanks for the quick fix guys.

        Show
        Jean-Pierre added a comment - for those of you following along at home - you can apply the fix to your project, you don't need to wait for the next build of Cordova. just copy the new image resources that Shazron added in the above commit, directly to your Capture.bundle and you are good to go. thanks for the quick fix guys.

          People

          • Assignee:
            Shazron Abdullah
            Reporter:
            Jean-Pierre
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development