Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: None
    • Component/s: cordova-weinre
    • Labels:

      Description

      2 JS files don't correctly handle https:

      web/index.js(64):
      — else if (protocol == "https:") {
      +++ else if (weinre_protocol == "https:") {

      web/target/target-script-min.js(3359):
      — pattern = /(http:\/\/(.*?)\/)/;
      +++ pattern = /(https?:\/\/(.*?)\/)/;

        Activity

        Hide
        artlogic James Kruth added a comment -

        The second issue has been fixed by CB-7438. The first issue is still a problem, and it's simply a typo. I'd be happy to submit a patch if that's necessary to get this fixed.

        Show
        artlogic James Kruth added a comment - The second issue has been fixed by CB-7438 . The first issue is still a problem, and it's simply a typo. I'd be happy to submit a patch if that's necessary to get this fixed.
        Hide
        pmuellr Patrick Mueller added a comment -

        Andrew / James - thanks for the report and comment.

        The patch here is easy enough - just the suggested fix to weinre.web/index.js - that it's easier for me to do this myself.

        Good to go after this single fix?

        Andrew, had you tried picking up a new weinre release, for a fix to the second problem?

        Show
        pmuellr Patrick Mueller added a comment - Andrew / James - thanks for the report and comment. The patch here is easy enough - just the suggested fix to weinre.web/index.js - that it's easier for me to do this myself. Good to go after this single fix? Andrew, had you tried picking up a new weinre release, for a fix to the second problem?
        Hide
        artlogic James Kruth added a comment -

        Patrick - I'm good with the single patch. Thanks for all your hard work!

        Show
        artlogic James Kruth added a comment - Patrick - I'm good with the single patch. Thanks for all your hard work!
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 891a61f73f27c171f5170327c18858ccf48841d2 in cordova-weinre's branch refs/heads/master from Patrick Mueller
        [ https://git-wip-us.apache.org/repos/asf?p=cordova-weinre.git;h=891a61f ]

        update for release 2.0.0-pre-I0Z7U9OV

        Show
        jira-bot ASF subversion and git services added a comment - Commit 891a61f73f27c171f5170327c18858ccf48841d2 in cordova-weinre's branch refs/heads/master from Patrick Mueller [ https://git-wip-us.apache.org/repos/asf?p=cordova-weinre.git;h=891a61f ] update for release 2.0.0-pre-I0Z7U9OV fix for https://issues.apache.org/jira/browse/CB-5718 Detection of HTTPS broken
        Hide
        pmuellr Patrick Mueller added a comment -

        I've commit the patch here:

        https://git-wip-us.apache.org/repos/asf?p=cordova-weinre.git;a=commit;h=891a61f73f27c171f5170327c18858ccf48841d2

        I've been having difficulties publishing to npm - if you'd like to try it before I get the issue resolved, you can install from the tarball, with this command:

        sudo npm -g install http://people.apache.org/~pmuellr/weinre/builds/2.0.0-pre-I0Z7U9OV/apache-cordova-weinre-2.0.0-pre-I0Z7U9OV-bin.tar.gz

        Show
        pmuellr Patrick Mueller added a comment - I've commit the patch here: https://git-wip-us.apache.org/repos/asf?p=cordova-weinre.git;a=commit;h=891a61f73f27c171f5170327c18858ccf48841d2 I've been having difficulties publishing to npm - if you'd like to try it before I get the issue resolved, you can install from the tarball, with this command: sudo npm -g install http://people.apache.org/~pmuellr/weinre/builds/2.0.0-pre-I0Z7U9OV/apache-cordova-weinre-2.0.0-pre-I0Z7U9OV-bin.tar.gz

          People

          • Assignee:
            pmuellr Patrick Mueller
            Reporter:
            Brocky Andrew Brock
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development