[CB-5059] The android implementation of file transfer plugin should not depend on the concrete class android.webkit.CookieManager

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Master
• Fix Version/s: Master
• Component/s: cordova-plugin-file-transfer (DEPRECATED)

Environment

cordova-android, git branch 3.0.x

• Assignee: Unassigned
• Reporter: Junmin
• Created: 11/Oct/13 09:34
• Updated: 23/Aug/18 07:08
• Resolved: 30/Mar/15 17:42

Description

The android implementation of file transfer plugin leverages the class android.webkit.CookieManager, which depends on the concrete web infrastructure android.webkit.WebView. This dependence ruins the portability of the plugin. For example, it could not run on a substantial implementation of CordovaWebView which based on a android third party component(such as chromium for android).

Following is the crash log when initializing the CookieManager without android.webkit.WebView:
I/dalvikvm(5006): java.lang.IllegalStateException: Call CookieSyncManager::createInstance() or create a webview before using this class
I/dalvikvm(5006): at android.webkit.JniUtil.checkInitialized(JniUtil.java:44)
I/dalvikvm(5006): at android.webkit.JniUtil.getDatabaseDirectory(JniUtil.java:65)
I/dalvikvm(5006): at android.webkit.CookieManagerClassic.nativeGetCookie(Native Method)
I/dalvikvm(5006): at android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:109)
I/dalvikvm(5006): at android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:96)
I/dalvikvm(5006): at org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:747)