Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-5026

Move setting of UIWebView properties into its own plugin from the core

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Won't Fix
    • Master
    • None
    • cordova-ios
    • None

    Description

      See: https://github.com/apache/cordova-ios/blob/c66fc82bd0a49b940e0a5beb1563ecdb48cc7120/CordovaLib/Classes/CDVViewController.m#L245-L400

      (except for the CDVLocalStorage stuff)

      This 150 line behemoth should be in its own plugin (with onload="true"). Not sure about removing it from core, but putting it in its own plugin in core is a start.

      Pros:

      • if iOS >= 8 adds more properties, and people want to stick to Cordova 3.A and we only support it in 3.B or 4.x, they only have to update a plugin and not the whole core.

      Cons:

      • if they rely on these settings, they will lose them when they upgrade if they don't install a plugin, this won't be any different when they moved from 2.x to 3.x
      • Yet Another Repo?

      NOTE:
      Do not forget to add docs, and upgrading docs.

      Attachments

        Activity

          People

            shazron Shazron Abdullah
            shazron Shazron Abdullah
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: