[CB-5012] Crash occurs because plugman adds extra information in iOS Info.plist when installing a plugin

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: Master
• Fix Version/s: 3.2.0
• Component/s: cordova-plugman
• Assignee: David Brett Rudd
• Reporter: Shazron Abdullah
• Created: 07/Oct/13 21:00
• Updated: 23/Aug/18 07:28
• Resolved: 15/Oct/13 01:15

Description

See attached .original.plist and .after-plugman.plist.

The plugin.xml used is: https://github.com/apache/cordova-labs/blob/86fb3afef5aaaba8e82e5bf0719b74b4a07582e0/statusbar/plugin.xml
(note the value it tries to add in the iOS Info.plist).

What plugman does is, it adds extra info (newlines, spaces) as the string value for the keys NSMainNibFile and NSMainNibFile~ipad in Info.plist. They had no values before. At runtime, iOS will search for these "values" and not finding the .nib files to load, then crash.

This is critical for plugins that need to modify the Info.plist, like the Facebook PhoneGap plugin. There was a pull request for this, but I don't know why it was closed exactly: https://github.com/apache/cordova-plugman/pull/21

Expected:
plugman should not modify plist keys that have empty string values.

Actual:
plugman adds a newline, 6 spaces, and another newline for keys that have empty string values.

Issue Links

• relates to: CB-5262 Adding config entries in plugin.xml for modifying .plist file results in whitespace entries for NSMainNibFile keys leading to App crashing