[CB-4850] Write the device UUID only when it does not exist

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Component/s: cordova-wp7 (DEFUNCT), cordova-wp8 (DEPRECATED)

Environment

Any

• Assignee: Jesse MacFadyen
• Reporter: Jonathan Naguin
• Created: 17/Sep/13 11:34
• Updated: 23/Aug/18 07:27
• Resolved: 18/Sep/13 21:59

Description

Currently, the device UUID is writen back to the IsolatedStorageFile in every run even when it is not necessary.

On CordovaView.xaml.cs:

string deviceUUID = "";

using (IsolatedStorageFile appStorage = IsolatedStorageFile.GetUserStoreForApplication())
{
    try
    {
        IsolatedStorageFileStream fileStream = new IsolatedStorageFileStream("DeviceID.txt", FileMode.Open, FileAccess.Read, appStorage);

        using (StreamReader reader = new StreamReader(fileStream))
        {
            deviceUUID = reader.ReadLine();
        }
    }
    catch (Exception /*ex*/)
    {
        deviceUUID = Guid.NewGuid().ToString();
    }

    Debug.WriteLine("Updating IsolatedStorage for APP:DeviceID :: " + deviceUUID);
    IsolatedStorageFileStream file = new IsolatedStorageFileStream("DeviceID.txt", FileMode.Create, FileAccess.Write, appStorage);
    using (StreamWriter writeFile = new StreamWriter(file))
    {
        writeFile.WriteLine(deviceUUID);
        writeFile.Close();
    }

}

The writing code should be moved into the catch after creating a new one as:

catch (Exception /*ex*/)
    {
        deviceUUID = Guid.NewGuid().ToString();

        IsolatedStorageFileStream file = new IsolatedStorageFileStream("DeviceID.txt", FileMode.Create, FileAccess.Write, appStorage);
        using (StreamWriter writeFile = new StreamWriter(file))
        {
            writeFile.WriteLine(deviceUUID);
            writeFile.Close();
        }
    }