Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-481

Patch Android cordova.js to call exec() instead of directly calling prompt()

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.6.0, 1.7.0, 1.8.0, 1.8.1, 1.9.0
    • 2.0.0
    • cordova-android, cordova-js
    • None

    Description

      The final call in Android's cordova-js after everything is ready is to tell native to unhide the webview. This is done via a prompt call with string "gap_init" or something along those lines.

      While this is fine, we already have the exec module in place to handle webview -> native communication. We should use that instead. It's kind of foolish to go one level below exec when we have the exec abstraction available and in place already.

      This would also help the testing tool Ripple: Android Cordova apps being emulated in Ripple would no longer see an annoying prompt following app startup!

      Bottom line: exec is our go-to for calling into native. Circumventing an abstraction we put into place does not make any sense, and unifies how our bridge works.

      Attachments

        Activity

          People

            filmaj Filip Maj
            filmaj Filip Maj
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: