Apache Cordova
  1. Apache Cordova
  2. CB-42

mediaPlaybackRequiresUserAction unable to be set to "NO"

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0
    • Component/s: iOS
    • Labels:
      None

      Description

      reported at: https://github.com/phonegap/phonegap-iphone/issues/318
      by: https://github.com/splendid

      It looks like the code that deals with checking the plist and setting the `mediaPlaybackRequiresUserAction` value is incorrect.

      it makes the assumption that this value is set to "NO" by default (which is incorrect); and as such does not allow a user to set this value to "NO".

      Relevant code: PhoneGapDelegate.m, lines 425-427:

      ```objective-c
      if ([mediaPlaybackRequiresUserAction boolValue] && [self.webView respondsToSelector:@selector(mediaPlaybackRequiresUserAction)])

      { self.webView.mediaPlaybackRequiresUserAction = YES; }

      ```

      (Apologies for not submitting a patch myself, I'm still battling #104)

        Activity

        Show
        Becky Gibson added a comment - fixed with this commit: https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=f60c315c262439f4acea74ca07b81933fe0a0b2a

          People

          • Assignee:
            Becky Gibson
            Reporter:
            Shazron Abdullah
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development