Apache Cordova
  1. Apache Cordova
  2. CB-4184

Adding plugin with remote dependencies to a cli project with multiple platforms yields warnings

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.0
    • Fix Version/s: None
    • Component/s: CLI
    • Labels:
      None

      Description

      Set up:

      $ cordova create tmp
      $ cd tmp
      $ cordova platform add ios android
      

      Then go to add a plugin with a remote dependency.

      What will happen is, in parallel, cordova-cli will invoke plugin.install, which in turn will invoke plugman.fetch, but it does so for each platform. So in parallel, plugman is attempting to fetch the same plugin twice and fetch it into the cli-generated project's plugins directory.

      This does not cause errors but there are a bunch of warning messages about files already existing.

      Perhaps we can make the cli aware of what's happening in this case and manually call fetch first, and only once, before invoking install for each platform.

        Activity

        Filip Maj created issue -
        Braden Shepherdson made changes -
        Field Original Value New Value
        Assignee Filip Maj [ filmaj ] Braden Shepherdson [ shepheb ]
        Hide
        ASF subversion and git services added a comment -

        Commit 1d6e3b3181af6cbac00b0fe055759feb4f39258b in branch refs/heads/master from Braden Shepherdson
        [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=1d6e3b3 ]

        CB-4184: Install plugins to platforms serially, not in parallel.

        This prevents plugman stepping on itself while installing dependencies
        across platforms.

        Show
        ASF subversion and git services added a comment - Commit 1d6e3b3181af6cbac00b0fe055759feb4f39258b in branch refs/heads/master from Braden Shepherdson [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=1d6e3b3 ] CB-4184 : Install plugins to platforms serially, not in parallel. This prevents plugman stepping on itself while installing dependencies across platforms.
        Braden Shepherdson made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        55d 17h 25m 1 Braden Shepherdson 05/Sep/13 16:39

          People

          • Assignee:
            Braden Shepherdson
            Reporter:
            Filip Maj
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development