[CB-364] remove calls to alert()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Component/s: cordova-js
• Assignee: Filip Maj
• Reporter: Patrick Mueller
• Created: 21/Mar/12 12:41
• Updated: 23/Aug/18 07:45
• Resolved: 26/Mar/12 00:25

Description

I've run into some cases of alert() usage in the cordova-js code. I think this is inappropriate, since we are using the cordova-js code in other environments than the browser, like the test harness. I end up seeing errors thrown on "alert() not defined" and such, which is masking the actual error from me.

Instead, we should define an alert()-y function somewhere - like cordova.alert(). This function can sniff if alert() is available, and if not, console.log() or the equivalent.