Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.5.0
    • Fix Version/s: 1.8.0
    • Component/s: iOS
    • Labels:
      None

      Description

      I just tested the 1.5.0 code, it definitely crashes during runtime for an iOS 3 device right now because of some iOS 4 code, namely registering for pause/resume lifecycle events that we didn't guard for, for devices < iOS 4.

      The fix is to guard the affected code using this:

      NSString* systemVersion = [[UIDevice currentDevice] systemVersion];
      BOOL isiOS4 = ([systemVersion compare:@"4.0" options:NSNumericSearch] != NSOrderedAscending);
      if (isiOS4) {
         // do your iOS 4 thing!
      }
      

      But I'm wondering if this is worth it since we are moving away from iOS 3. See CB-93

      1. iOS3-MobileSpec.png
        59 kB
        Shazron Abdullah

        Issue Links

          Activity

          Shazron Abdullah created issue -
          Shazron Abdullah made changes -
          Field Original Value New Value
          Link This issue is related to CB-93 [ CB-93 ]
          Hide
          Shazron Abdullah added a comment -

          This is important to fix if we implement CB-93, in case we/someone decides to maintain a branch that supports iOS 3 as well.

          Show
          Shazron Abdullah added a comment - This is important to fix if we implement CB-93 , in case we/someone decides to maintain a branch that supports iOS 3 as well.
          Hide
          Randy McMillan added a comment -

          I would agree that it is impractical to maintain backwards support for iOS3.

          Show
          Randy McMillan added a comment - I would agree that it is impractical to maintain backwards support for iOS3.
          Shazron Abdullah made changes -
          Link This issue is related to CB-93 [ CB-93 ]
          Shazron Abdullah made changes -
          Link This issue blocks CB-93 [ CB-93 ]
          Christian Grobmeier made changes -
          Link This issue relates to CB-810 [ CB-810 ]
          Hide
          Shazron Abdullah added a comment -

          The native code has been fixed and will be committed soon, and I ran mobile-spec on it - 4 failures (awesome) but they are relatively benign.

          Show
          Shazron Abdullah added a comment - The native code has been fixed and will be committed soon, and I ran mobile-spec on it - 4 failures (awesome) but they are relatively benign.
          Shazron Abdullah made changes -
          Attachment iOS3-MobileSpec.png [ 12530480 ]
          Hide
          Shazron Abdullah added a comment -

          Forgot to mention - the mobile-spec failures are attached as an image.

          Show
          Shazron Abdullah added a comment - Forgot to mention - the mobile-spec failures are attached as an image.
          Shazron Abdullah made changes -
          Fix Version/s 1.8.0 [ 12319550 ]
          Hide
          Shazron Abdullah added a comment -

          NOTE: To test on iOS 3.x, you need to included the json2 library locally in your www and include the script tag referencing it. iOS 3 does not include the json2 library, whereas iOS versions newer than it do.

          Fix commit - http://git-wip-us.apache.org/repos/asf/incubator-cordova-ios/commit/982d0bb3

          Show
          Shazron Abdullah added a comment - NOTE: To test on iOS 3.x, you need to included the json2 library locally in your www and include the script tag referencing it. iOS 3 does not include the json2 library, whereas iOS versions newer than it do. Fix commit - http://git-wip-us.apache.org/repos/asf/incubator-cordova-ios/commit/982d0bb3
          Shazron Abdullah made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          Gavin made changes -
          Link This issue blocks CB-93 [ CB-93 ]
          Gavin made changes -
          Link This issue is depended upon by CB-93 [ CB-93 ]

            People

            • Assignee:
              Shazron Abdullah
              Reporter:
              Shazron Abdullah
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development