[CB-2502] iOS: CDVViewController's commandDelegate property should be typed to the protocol

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Master
• Fix Version/s: 2.6.0
• Component/s: cordova-ios
• Assignee: Andrew Grieve
• Reporter: Kevin Hawkins
• Created: 20/Feb/13 17:24
• Updated: 23/Aug/18 07:39
• Resolved: 21/Feb/13 13:59

Description

CDVViewController's commandDelegate property is typed as CDVCommandDelegateImpl, the concrete implementation of the CDVCommandDelegate protocol. From an object-oriented design standpoint, we want to property to conform to the protocol API, not the implementation. This would come into play particularly if a consumer was providing their own implementation of the protocol, as an override to the parent class's definition.