Apache Cordova
  1. Apache Cordova
  2. CB-2053

camera.getPicture label displays 'Photos' when mediaType is set to Videos

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.2.0
    • Fix Version/s: 2.7.0
    • Component/s: iOS
    • Labels:
      None

      Description

      The label on the UIImagePickerController is set to 'Photos' regardless of mediaType.

        Activity

        Hide
        Cory Thompson added a comment -
        Show
        Cory Thompson added a comment - Changes: https://github.com/coryjthompson/incubator-cordova-ios/commit/1bc7b62c614c9f0202a2866e540b2ff32aec7686 Any feedback would be awesome! Thank you
        Hide
        Shazron Abdullah added a comment -

        That's great! If you'd like to contribute that, please send a pull request. Note that the repo to send a pull from should be http://github.com/apache/cordova-ios now (note no more incubator prefix).

        Show
        Shazron Abdullah added a comment - That's great! If you'd like to contribute that, please send a pull request. Note that the repo to send a pull from should be http://github.com/apache/cordova-ios now (note no more incubator prefix).
        Hide
        Shazron Abdullah added a comment -
        Show
        Shazron Abdullah added a comment - Pull request: https://github.com/apache/cordova-ios/pull/4
        Hide
        Shazron Abdullah added a comment -

        Punting to 2.4.0 for unresolved localization issues (see the pull request)

        Show
        Shazron Abdullah added a comment - Punting to 2.4.0 for unresolved localization issues (see the pull request)
        Hide
        James Jong added a comment -

        Shazron Abdullah
        I'll work on getting this old one closed out. Would you like a pull request on top of pull #4 or do you want all the changes together in one pull request?

        Show
        James Jong added a comment - Shazron Abdullah I'll work on getting this old one closed out. Would you like a pull request on top of pull #4 or do you want all the changes together in one pull request?
        Hide
        James Jong added a comment -

        I cherry-picked the other commit in the pull request.

        I also added localized string in this commit:
        https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;a=commit;h=aaf5ccb3f561cb3fb935afa73d5f1a6dda98fa35

        Show
        James Jong added a comment - I cherry-picked the other commit in the pull request. I also added localized string in this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;a=commit;h=aaf5ccb3f561cb3fb935afa73d5f1a6dda98fa35

          People

          • Assignee:
            James Jong
            Reporter:
            Cory Thompson
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development