[CB-14041] Programming error in cordova-android check_reqs.js

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 7.1.0
• Component/s: cordova-android
• Labels: easyfix

Environment

cordova 8.0.0

android 7.1.0

windows 10

Eclipse neon

• Flags: Patch, Important
• Assignee: Joey Robert Bowser
• Reporter: Allan Steen Schytt
• Created: 19/Apr/18 06:15
• Updated: 19/Apr/18 06:15

Description

Programming error in check_reqs.js, line 130

programmer doesnt iterate through a directory for gradle, checks only for first entry

 

    var dirs = fs.readdirSync(androidStudioPath);
    if (dirs[0].split('-')[0] === 'gradle') {
         return path.join(androidStudioPath, dirs[0], 'bin', 'gradle');
     }

working solution

    var dirs = fs.readdirSync(androidStudioPath);
    for (var i = 0; i< dirs.length ; i++){
         if (dirs[i].split('-')[0] === 'gradle') 
             return path.join(androidStudioPath, dirs[i], 'bin', 'gradle');
     }