[CB-13985] Plugin installation fails if the plugin requires variables on platform add

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: cordova-plugman
• Labels: bug
• Assignee: Unassigned
• Reporter: Benjamin Räder
• Created: 16/Mar/18 15:25
• Updated: 13/May/18 12:14

Description

If you have a plugin defined in your plugin.xml like this:

<plugin name="cordova-plugin-facebook4" spec="git+https://github.com/XXXXXXXXXXXX/cordova-plugin-facebook4.git">
<variable name="APP_ID" value="1234567890" /> 
<variable name="APP_NAME" value="Testapp" />
</plugin>

package.json:

"cordova-plugin-facebook4": { "APP_ID": "1234567890", "APP_NAME": "Testapp" },

And you try to add a new platform to your project:

cordova platform add ios

The plugin cannot be installed because the variables are not passed during the installation phase:

Installing "cordova-plugin-facebook4" for ios Failed to install 'cordova-plugin-facebook4': Error: Variable(s) missing: APP_ID, APP_NAME at Object.mergeVariables (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/variable-merge.js:58:15) at /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:315:44 at _fulfilled (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:787:54) at self.promiseDispatch.done (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:816:30) at Promise.promise.promiseDispatch (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:749:13) at /usr/local/lib/node_modules/cordova/node_modules/q/q.js:557:44 at flush (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:108:17) at process._tickCallback (internal/process/next_tick.js:150:11) Error: Variable(s) missing: APP_ID, APP_NAME