Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-13592

comment is not removed on removing embedded frameworks

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: Master
    • Fix Version/s: Master
    • Component/s: cordova-node-xcode
    • Labels:
      None
    • Environment:

      Mac OS high Sierra.

      Description

      Currently after adding an embedded framework, 4 entries are added to the PBXBuildFileSection.

      {{ "128CD4F705D24987A12F213E":

      { "isa": "PBXBuildFile", "fileRef": "021AA25C78F942DA94C24904", "fileRef_comment": "EmbedThirdParty.framework" }

      ,
      "128CD4F705D24987A12F213E_comment": "EmbedThirdParty.framework in Frameworks",
      "B9B17AE7AA7C4663BA933B64": {
      "isa": "PBXBuildFile",
      "fileRef": "021AA25C78F942DA94C24904",
      "fileRef_comment": "EmbedThirdParty.framework",
      "settings":

      { "ATTRIBUTES": ["CodeSignOnCopy"] }

      },
      "B9B17AE7AA7C4663BA933B64_comment": "EmbedThirdParty.framework in Embed Frameworks",}}

      After calling removeFramework function, the current existing code will incorrectly leave a orphan entry in the PBXFileSection:

      {{ "B9B17AE7AA7C4663BA933B64_comment": "EmbedThirdParty.framework in Embed Frameworks",}}

      Pull request #5 fixes this issue, and adds a relevant unit test in removeFramework.js
      https://github.com/apache/cordova-node-xcode/pull/5

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                anis Anis Kadri
                Reporter:
                kelvinhokk Kelvin Ho
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - 2h
                  2h
                  Remaining:
                  Remaining Estimate - 2h
                  2h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified