[CB-12218] inconsistent null handling between EVAL and ONLINE bridge modes

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.0.0
• Component/s: cordova-android

Environment

Android

• Assignee: Joey Robert Bowser
• Reporter: Alan Kinzie
• Created: 05/Dec/16 16:45
• Updated: 23/Aug/18 07:51
• Resolved: 03/Jan/18 19:28

Description

If the Android native code invokes the success callback like this:
callbackContext.success(null);
then the value given to the javascript callback changes depending on the bridge type used.

If the ONLINE_EVENT type is used, then null will be passed to the javascript callback.
ie: if result is the parameter of the javascript success callback then
result === null // will be true
result === "" // will be false

If the EVAL_BRIDGE type is used, then an empty string will be passed to the javascript callback.
ie: if result is the parameter of the javascript success callback then
result === null // will be false
result === "" // will be true

The value of the parameter given to the success callback should not change depending on the bridge type. Since ONLINE_EVENT was the default before cordova android 6.0.0, I am inclined to think the ONLINE bridge is doing the correct behaviour. Also, converting null to an empty string loses information. Therefore I think the EVAL mode should to be changed to be consistent with the ONLINE mode.

Issue Links

• links to: GitHub Pull Request #425