Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: None
    • Fix Version/s: 4.5.0
    • Component/s: cordova-windows
    • Labels:
      None

      Description

      As discussed in https://forums.adobe.com/message/9123283 and https://github.com/litehelpers/Cordova-sqlite-legacy-build-support/issues/10 it is not possible to build on PhoneGap Build for Windows with a plugin such as https://github.com/litehelpers/Cordova-sqlite-legacy-build-support or https://github.com/litehelpers/Cordova-sqlite-evcore-extbuild-free. The solution discussed in https://github.com/litehelpers/Cordova-sqlite-legacy-build-support/issues/10 is to build the Windows C++ library by hand then include the WinMD file in plugin.xml just like https://github.com/phonegap/phonegap-plugin-barcodescanner/blob/master/plugin.xml#L65-L67.

      But as discussed in https://github.com/litehelpers/Cordova-sqlite-legacy-build-support/issues/10 this is still not possible since we need to include both WinMD and DLL files in case of a C++ library.

      I hereby raise this issue to fix cordova-windows to support WinMD+DLL for C++ libraries such as https://github.com/litehelpers/Cordova-sqlite-legacy-build-support. This is a blocking issue for one of my customers.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user vladimir-kotikov opened a pull request:

          https://github.com/apache/cordova-lib/pull/513

          CB-12189 windows: Add `implementation` attribute to frameworks

          The attribute is windows-specific and allows to specify implementation for WinMD components, written in C++

          <!--
          Please make sure the checklist boxes are all checked before submitting the PR. The checklist
          is intended as a quick reference, for complete details please see our Contributor Guidelines:

          http://cordova.apache.org/contribute/contribute_guidelines.html

          Thanks!
          -->

              1. Platforms affected
              1. What does this PR do?
              1. What testing has been done on this change?
              1. Checklist
          • [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
          • [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
          • [ ] Added automated test coverage as appropriate for this change.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/vladimir-kotikov/cordova-lib CB-12189

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-lib/pull/513.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #513


          commit 5be6a8166fd9785dec095c99836cba725fb4947e
          Author: Vladimir Kotikov <kotikov.vladimir@gmail.com>
          Date: 2016-12-21T12:00:57Z

          CB-12189 Add implementation attribute to framework

          The attribute is windows-specific and allows to specify implementation for WinMD components, written in C++


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/513 CB-12189 windows: Add `implementation` attribute to frameworks The attribute is windows-specific and allows to specify implementation for WinMD components, written in C++ <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> Platforms affected What does this PR do? What testing has been done on this change? Checklist [x] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [X] Commit message follows the format: " CB-3232 : (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vladimir-kotikov/cordova-lib CB-12189 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/513.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #513 commit 5be6a8166fd9785dec095c99836cba725fb4947e Author: Vladimir Kotikov <kotikov.vladimir@gmail.com> Date: 2016-12-21T12:00:57Z CB-12189 Add implementation attribute to framework The attribute is windows-specific and allows to specify implementation for WinMD components, written in C++
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user vladimir-kotikov opened a pull request:

          https://github.com/apache/cordova-docs/pull/671

          CB-12189 windows: Document `implementation` attribute

          <!--
          Please make sure the checklist boxes are all checked before submitting the PR. The checklist
          is intended as a quick reference, for complete details please see our Contributor Guidelines:

          http://cordova.apache.org/contribute/contribute_guidelines.html

          Thanks!
          -->

              1. Platforms affected
              1. What does this PR do?
              1. What testing has been done on this change?
              1. Checklist

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/vladimir-kotikov/cordova-docs CB-12189

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-docs/pull/671.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #671


          commit d2c53d80bf240b1f416dd13483f44d86b82650db
          Author: Vladimir Kotikov <kotikov.vladimir@gmail.com>
          Date: 2016-12-21T11:09:29Z

          CB-12189 Document `implementation` attribute


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-docs/pull/671 CB-12189 windows: Document `implementation` attribute <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> Platforms affected What does this PR do? What testing has been done on this change? Checklist [X] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [X] Commit message follows the format: " CB-3232 : (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vladimir-kotikov/cordova-docs CB-12189 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/671.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #671 commit d2c53d80bf240b1f416dd13483f44d86b82650db Author: Vladimir Kotikov <kotikov.vladimir@gmail.com> Date: 2016-12-21T11:09:29Z CB-12189 Document `implementation` attribute
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vladimir-kotikov commented on the issue:

          https://github.com/apache/cordova-lib/pull/513

          Travis build failures look irrelevant to this PR

          Show
          githubbot ASF GitHub Bot added a comment - Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-lib/pull/513 Travis build failures look irrelevant to this PR
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vladimir-kotikov commented on the issue:

          https://github.com/apache/cordova-windows/pull/219

          @daserge could you take a look please?

          Show
          githubbot ASF GitHub Bot added a comment - Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/219 @daserge could you take a look please?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user daserge commented on a diff in the pull request:

          https://github.com/apache/cordova-windows/pull/219#discussion_r93464493

          — Diff: spec/unit/pluginHandler/windows.spec.js —
          @@ -304,6 +309,47 @@ describe('windows project handler', function ()

          { xpath = 'Reference[@Include="dummy6"]/HintPath'; validateInstalledProjects('framework', frameworks[5], xpath, ['windows', 'windows10', 'phone']); }

          );
          +
          + it('with .winmd and .dll files', function() {
          — End diff –

          Does this spec check that dll files have been actually copied? ([according to this](https://github.com/apache/cordova-windows/pull/219/files#diff-7bcd02ec7f03ffbb25512bd1f4a0d388R99))

          Show
          githubbot ASF GitHub Bot added a comment - Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/219#discussion_r93464493 — Diff: spec/unit/pluginHandler/windows.spec.js — @@ -304,6 +309,47 @@ describe('windows project handler', function () { xpath = 'Reference[@Include="dummy6"]/HintPath'; validateInstalledProjects('framework', frameworks[5], xpath, ['windows', 'windows10', 'phone']); } ); + + it('with .winmd and .dll files', function() { — End diff – Does this spec check that dll files have been actually copied? ( [according to this] ( https://github.com/apache/cordova-windows/pull/219/files#diff-7bcd02ec7f03ffbb25512bd1f4a0d388R99 ))
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user daserge commented on a diff in the pull request:

          https://github.com/apache/cordova-windows/pull/219#discussion_r93460566

          — Diff: template/cordova/lib/PluginInfo.js —
          @@ -115,6 +115,33 @@ function PluginInfo(dirname)

          { var configFiles = parentGetConfigFiles(platform); return processChanges(configFiles); }

          ;
          +
          + this.getFrameworks = function(platform) {
          — End diff –

          nit: [outdated comment](https://github.com/apache/cordova-windows/pull/219/files#diff-93a26ea6e269125a5b151c4176a3b42bL100)

          Show
          githubbot ASF GitHub Bot added a comment - Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/219#discussion_r93460566 — Diff: template/cordova/lib/PluginInfo.js — @@ -115,6 +115,33 @@ function PluginInfo(dirname) { var configFiles = parentGetConfigFiles(platform); return processChanges(configFiles); } ; + + this.getFrameworks = function(platform) { — End diff – nit: [outdated comment] ( https://github.com/apache/cordova-windows/pull/219/files#diff-93a26ea6e269125a5b151c4176a3b42bL100 )
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user matrosov-nikita commented on the issue:

          https://github.com/apache/cordova-windows/pull/219

          @vladimir-kotikov, @daserge, updated.

          Show
          githubbot ASF GitHub Bot added a comment - Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-windows/pull/219 @vladimir-kotikov, @daserge, updated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vladimir-kotikov commented on the issue:

          https://github.com/apache/cordova-windows/pull/219

          Rebased on top of master and force-pushed, will merge once tests pass

          Show
          githubbot ASF GitHub Bot added a comment - Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/219 Rebased on top of master and force-pushed, will merge once tests pass
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit ae433f67579d7ca4dbec8d0da419b66b2a9bccf5 in cordova-windows's branch refs/heads/master from Vladimir
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=ae433f6 ]

          CB-12189: Add support for WinMD and DLL combination

          This closes #219

          Show
          jira-bot ASF subversion and git services added a comment - Commit ae433f67579d7ca4dbec8d0da419b66b2a9bccf5 in cordova-windows's branch refs/heads/master from Vladimir [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=ae433f6 ] CB-12189 : Add support for WinMD and DLL combination This closes #219
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-windows/pull/219

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/219
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit df2da4cbf515dfc8e8131170972165b7d9883380 in cordova-lib's branch refs/heads/master from Vladimir Kotikov
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=df2da4c ]

          CB-12189 Add implementation attribute to framework

          The attribute is windows-specific and allows to specify implementation for WinMD components, written in C++

          This closes #513

          Show
          jira-bot ASF subversion and git services added a comment - Commit df2da4cbf515dfc8e8131170972165b7d9883380 in cordova-lib's branch refs/heads/master from Vladimir Kotikov [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=df2da4c ] CB-12189 Add implementation attribute to framework The attribute is windows-specific and allows to specify implementation for WinMD components, written in C++ This closes #513
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-lib/pull/513

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/513
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e4390a3ab07527295ece6618e98ff6bee1adc980 in cordova-docs's branch refs/heads/master from Vladimir Kotikov
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=e4390a3 ]

          CB-12189 Document `implementation` attribute

          This closes #671

          Show
          jira-bot ASF subversion and git services added a comment - Commit e4390a3ab07527295ece6618e98ff6bee1adc980 in cordova-docs's branch refs/heads/master from Vladimir Kotikov [ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=e4390a3 ] CB-12189 Document `implementation` attribute This closes #671
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-docs/pull/671

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/671

            People

            • Assignee:
              Unassigned
              Reporter:
              brodybits Chris Brody
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development