Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-11787 Fixes for cocoapods plugin support
  3. CB-11790

Check that Cocoapods is installed by checking `pod install` return code, show help text

VotersStop watchingWatchersLinkUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • None
    • cordova-ios
    • None

    Description

      Line: https://github.com/apache/cordova-ios/blob/826db773df6b0297a9d0b2e7889b9a028a80fe5f/bin/templates/scripts/cordova/lib/podMod.js#L59

      If it is not installed, we must error out and warn the user what to do. Currently, it just silently fails (pod install is called, but its error code is not checked).

      We need to decide what to do with the user experience issue if pod install is first run – this triggers a Cocoapods repo clone, which at the time I write this is 475MB. The time to download this repo is non-trivial, and the size of the repo increases linearly each day. We should add a notice to the output that it might take a long time.

      Additionally, we could report the size of the Cocoapods repo by using the Github API like this Chrome Extension: https://github.com/harshjv/github-repo-size

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            shazron Shazron Abdullah
            shazron Shazron Abdullah
            Votes:
            0 Vote for this issue
            Watchers:
            3 Stop watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment