Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-11683

Cordova-Android fails to properly add the source of a custom plugin if its source-file.src points to a directory and plugin is being installed in --link mode

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3.0
    • Component/s: cordova-android
    • Labels:
    • Environment:

      Windows 10

      Description

      I have cerated a custom plugin. In my plugin.xml I've added java sources directory with the following XML tag:

      <source-file src="src/com/thisisdir/" target-dir="src/com/" />

      Next I tried to install that plugin using the following command:

      cordova plugin add ..\AuthenticatorPlugin --link

      Unfortunatetly that only creates a useless 0-byte file in the destination folder instead of proper link.

      This resembles behaviour of Windows' mklink command, which does exactly this when trying to create the link to the directory without the /D parameter. This is clearly bad design. The command failed to do its job but exited normally instead of presenting any error message. Cordova shoudln't replicate that behaviour and handle folder linking on its own. Therefore we should either:

      • fail the task on attempts to link a directory,
      • handle directory linking properly.

      I think the second option is way better

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                sprzedamsanki@gmail.com Szymon Drosdzol
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: