[CAY-2380] ReferenceMap should not store or return null values

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.1.M1
• Fix Version/s: 4.1.M2
• Component/s: Core Library
• Assignee: Nikita Timofeev
• Reporter: Nikita Timofeev
• Created: 13/Nov/17 13:45
• Updated: 25/Jan/18 09:03
• Resolved: 25/Jan/18 09:03

Description

This one from dev@list:

The problem is in ReferenceMap.values(). If the GC runs between
checkReferenceQueue() and the last v.get(), then null can be added to the
collection (when using the default WeakValueMap). keySet() and entrySet()
have similar issues.

Previously used class from commons-collections forbid null values so our implementation should do the same, this allows to clear nulls not only explicitly in reference queue check but also inside any operation.

keySet() method will be intact as we can't make any assumption about when returned keys will be used thus it's impractical to additionally clear stale references in that method.