[CAY-237] RollBack flattened inserts

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1 [LEGACY]
• Fix Version/s: 1.1 [LEGACY]
• Component/s: Core Library
• Environment: Windows 2000, Tomcat 5.0.x and JDK 1.4.x
• Assignee: Andrus Adamchik
• Reporter: Jorge Sopena
• Created: 12/Nov/04 17:45
• Updated: 20/Nov/04 22:03
• Resolved: 19/Nov/04 07:30

Description

I've got the entities Smartcard and Product, and a flattened relatioship between them, listPreloadProducts.
The problem arises when I create a new Smartcard with some Products and an error happens during the creation.
For example a Unique Index constraint is broken. At this moment a CayenneRuntimeException is thrown, I catch the Exception and I do a DataContext.rollbackChanges().
After this, I can't do any insert, I've got always a CayenneRuntimeException.

Trying to find the source of the exception I've realised that DataContext.rollbackChanges() doesn't delete the flattenedInserts List in the ObjectStore.
This means there is a FlattenedRelationshipInfo Object in the List where the DataObject source is TRANSIENT.
So next time I try todo commit,this flattenedInserts List is iterated in ContextCommit.categorizeFlattenedInsertsAndCreateBatches().
In this iteration is only checked if any DataObject in the relationship is DELETED. So the FlattenedRelationshipInfo is tried to be inserted and an error happens.

Here it is the exception stack trace

java.lang.NullPointerException at org.objectstyle.cayenne.access.FlattenedRelationshipInfo.buildJoinSnapshot(FlattenedRelationshipInfo.java:214)
at org.objectstyle.cayenne.access.FlattenedRelationshipInfo.buildJoinSnapshotForInsert(FlattenedRelationshipInfo.java:239)
at org.objectstyle.cayenne.access.ContextCommit.categorizeFlattenedInsertsAndCreateBatches(ContextCommit.java:720)

at org.objectstyle.cayenne.access.ContextCommit.commit(ContextCommit.java:143)

at org.objectstyle.cayenne.access.DataContext.commitChanges(DataContext.java:1231)

at org.objectstyle.cayenne.access.DataContext.commitChanges(DataContext.java:1201)

at KeyFlyManager.Persistence.AccessDB.commit(AccessDB.java:104)