[CAY-2144] cdbimport fails for databases which don't support catalogs

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.M3
• Fix Version/s: 4.0.M4
• Component/s: Non-GUI Tools
• Assignee: Nikita Timofeev
• Reporter: Dzmitry Kazimirchyk
• Created: 15/Nov/16 17:44
• Updated: 21/Nov/16 10:34
• Resolved: 21/Nov/16 10:34

Description

cdbimport maven goal fails if database doesn't support catalogs (e.g. postgres):

[ERROR] Failed to execute goal org.apache.cayenne.plugins:maven-cayenne-plugin:4.0.M4-SNAPSHOT:cdbimport (default-cli) on project test-db: Error creating DataSource (org.apache.cayenne.datasource.DriverDataSource@4f8b4bd0) or DbAdapter (org.apache.cayenne.dba.postgres.PostgresAdapter@4e904fd5) for DataNodeDescriptor (org.apache.cayenne.configuration.DataNodeDescriptor@b18c4): Your database does not support catalogs on reverse engineering. It allows to connect to only one at the moment. Please don't note catalogs as param. -> [Help 1]

This seems to be due to this logic https://github.com/apache/cayenne/blob/1455622fad83db8d181e2dfb0ba5f6efeeeae37e/cayenne-dbsync/src/main/java/org/apache/cayenne/dbsync/reverse/filters/FiltersConfigBuilder.java#L321 which is always adding empty catalogs to the reverse engineering configuration.

Issue Links

• links to: GitHub Pull Request #134