Cayenne
  1. Cayenne
  2. CAY-1634

[PATCH] In ChildDiffLoader.nodePropertyChanged the oldValue is not passed to writeProperty

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1B1
    • Fix Version/s: 3.1B1
    • Component/s: Core Library
    • Labels:
    • Environment:
      Mac 10.6

      Description

      In ChildDiffLoader.nodePropertyChanged the oldValue is not passed to descriptor.writeProperty. This can cause a problem for people trying to observe changes to objects since if the newValue is null current it makes it look like oldValue is also null resulting in no change. The actual oldValue needs to be passed so that client code has the right information to react correctly.

        Activity

        John Huss created issue -
        Hide
        John Huss added a comment -

        Patch attached

        Show
        John Huss added a comment - Patch attached
        John Huss made changes -
        Field Original Value New Value
        Attachment childDiffLoader-patch.txt [ 12501632 ]
        Hide
        Andrus Adamchik added a comment -

        Thanks! Applied.

        Show
        Andrus Adamchik added a comment - Thanks! Applied.
        Andrus Adamchik made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 3.1M4 [ 12317958 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        186d 19h 9m 1 Andrus Adamchik 05/May/12 12:56

          People

          • Assignee:
            Unassigned
            Reporter:
            John Huss
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 0.5h
              0.5h
              Remaining:
              Remaining Estimate - 0.5h
              0.5h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development