[CAY-1487] Access to ObjectStore.objectMap not thread safe when creating new object instance (and processing snaphot events)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0 branch
• Fix Version/s: 2.0.5
• Component/s: Core Library
• Assignee: Unassigned
• Reporter: Donald Vrakking
• Created: 29/Sep/10 15:25
• Updated: 11/Nov/10 02:42
• Resolved: 11/Nov/10 02:42

Description

The method ObjectStore.registerNode(..) is not synchronized, while getNode(..) is. The objectMap can be accessed in a thread-unsafe way when a new object instance is created and when at the same time snapshotevents are processed.

When creating the instance, the unsafe registerNode method is used. It will start looping in the objectMap when at the same time when an EventDispatch thread tries to acces the objectMap through getNode(). The dispatch threads will go in a WAIT state which eventually results in a completely frozen application.

I noticed that in cayenne 3 the registerNode() method is synchronized. Can such a fix also be applied to a cayenne 2.0.5 release?