[CAUSEWAY-2982] I18n does not load translation files

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Resolved
• Affects Version/s: 2.0.0-M7
• Fix Version/s: 2.0.0-M8
• Component/s: Core
• Assignee: Andi Huber
• Reporter: Miklós Győrfi
• Created: 23/Mar/22 12:08
• Updated: 23/Mar/22 16:48
• Resolved: 23/Mar/22 13:11

Description

PoReader does not check ALL translation candidates.

In PoReader.readPoElseNull(final Locale locale)

for (final String candidate : candidates) {
    final List<String> lines = readUrl(candidate);
    if(lines != null) {
        return lines;
    }
} 

always returns at the first candidate, regardless of existing of the file/resource, as readUrl never returns null, because readUrl is a stream collect. I think it should carry on loading resources when lines == null || lines.size() == 0.

If I had translation_hu.po, it was the last candidate, it was never loaded.