[CAUSEWAY-1419] Simplify session management handling (IllegalStateException when integ tests complete).

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.12.1
• Fix Version/s: 1.13.0
• Component/s: Core
• Assignee: Daniel Keir Haywood
• Reporter: Daniel Keir Haywood
• Created: 31/May/16 05:40
• Updated: 11/Jul/16 19:36
• Resolved: 01/Jun/16 08:50

Description

This exception is the result of stricter exception handling introduced during
ISIS-1414:

} else {
                        T service = serviceByThread.get();
                        if(service == null) {
                            // shouldn't happen...
                            throw new IllegalStateException("No service of type " + cls + " is available on this ");
                        }
                        final Object proxiedReturn = proxyMethod.invoke(service, args);
                        return proxiedReturn;

resulting in the following exception when integ tests complete:

11:03:24,485  [IsisContext          Thread-1   INFO ]  Shutting down thread: main
java.lang.IllegalStateException: No service of type class org.apache.isis.applib.services.command.CommandContext is available on this 
	at org.apache.isis.core.runtime.services.ServiceInstantiator$2.invoke(ServiceInstantiator.java:217)
	at org.apache.isis.applib.services.command.CommandContext_$$_jvst3a6_2.getCommand(CommandContext_$$_jvst3a6_2.java)
	at org.apache.isis.core.runtime.system.persistence.PersistenceSession.completeCommandFromInteractionAndClearDomainEvents(PersistenceSession.java:489)
	at org.apache.isis.core.runtime.system.persistence.PersistenceSession.close(PersistenceSession.java:424)
	at org.apache.isis.core.runtime.system.session.IsisSession.close(IsisSession.java:95)
	at org.apache.isis.core.runtime.system.session.IsisSession.closeAll(IsisSession.java:111)
	at org.apache.isis.core.runtime.system.context.IsisContext.shutdownAllThreads(IsisContext.java:601)
	at org.apache.isis.core.runtime.system.context.IsisContext.closeAllSessionsInstance(IsisContext.java:274)
	at org.apache.isis.core.runtime.system.context.IsisContext.closeAllSessions(IsisContext.java:363)
	at org.apache.isis.core.runtime.system.IsisSystem.shutdown(IsisSystem.java:344)
	at org.apache.isis.core.integtestsupport.IsisSystemForTest.shutdown(IsisSystemForTest.java:490)
	at org.apache.isis.core.integtestsupport.IsisSystemForTest.access$100(IsisSystemForTest.java:76)
	at org.apache.isis.core.integtestsupport.IsisSystemForTest$Builder$1.run(IsisSystemForTest.java:302)