[CASSANDRA-9763] PartitionUpdate must sort() before returning rowCount()

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Duplicate
• Fix Version/s: 3.0 alpha 1
• Severity: Normal
• Assignee: Benedict Elliott Smith
• Reporter: Benedict Elliott Smith

Authors

Benedict Elliott Smith

Reviewers

Sylvain Lebresne

• Created: 08/Jul/15 21:33
• Updated: 16/Apr/19 09:31
• Resolved: 09/Jul/15 08:00

Description

PartitionUpdate does not ensure its row count is accurate before reporting it. This can result in, for instance, null records making their way into Memtables because fewer rows were provided than promised.

This patch fixes this, but makes no effort to avoid similar problems. Once the refactor makes its way into mainline, I'll have a look at the hierarchy as a whole. I think it is very likely we can do away with the distinction between btree/array backed implementations, so there are fewer places to introduce these mistakes. The btree has the benefit of being inherently immutable, so these sorts of states cannot be reached.

Issue Links

• duplicates: CASSANDRA-9746 Fix PartitionUpdate.rowCount()
• is broken by: CASSANDRA-8099 Refactor and modernize the storage engine