Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-9486

LazilyCompactedRow accumulates all expired RangeTombstones

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Urgent
    • Resolution: Fixed
    • Fix Version/s: 2.0.16, 2.1.6, 2.2.0 rc1
    • Component/s: None
    • Labels:
      None
    • Severity:
      Critical
    • Since Version:

      Description

      LazilyCompactedRow initializes a ColumnIndex.Builder to use its RangeTombstone.Tracker, but it only calls update() with a RT argument, never an atom. The Tracker only ever adds if it receives a RT, never removes. So all the RT ever seen for the partition (that have expired) remain in memory until the compaction completes. To make matters worse, this then forces a linear scan of all of these RT for each live cell we add, so this extra load hangs around for a long time, and compactions stall.

      This issue is biting one of our users badly (at least, it seems likely to be this issue), and there may be others. This user is not even making use of RT extensively themselves, only collections (presumably with a complete overwrite of the contents of the collection, resulting in a RT being generated).

      Probably the best solution is to make the RT addition itself remove any already present that are no longer helpful.

        Attachments

        1. 0001-9486.patch
          2 kB
          Marcus Eriksson

          Issue Links

            Activity

              People

              • Assignee:
                slebresne Sylvain Lebresne
                Reporter:
                benedict Benedict Elliott Smith
                Authors:
                Sylvain Lebresne
                Reviewers:
                Benedict Elliott Smith
              • Votes:
                1 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: