[CASSANDRA-9239] OHCProvider doesn't write ByteBuffers with non-zero position correctly

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 2.2.0 beta 1
• Severity: Low
• Assignee: Tom Hobbs
• Reporter: Tom Hobbs

Authors

Tom Hobbs

Reviewers

Robert Stupp

• Created: 24/Apr/15 19:48
• Updated: 16/Apr/19 09:31
• Resolved: 25/Apr/15 08:14

Description

In OHCProvider.DataOutputPlusAdapter.write(), we do the following:

if (buffer.hasArray())
    out.write(buffer.array(), buffer.arrayOffset(), buffer.remaining());

This doesn't behave correctly if the ByteBuffer has a non-zero position. Instead, we need to add buffer.position() to buffer.arrayOffset().

At least against CASSANDRA-8099, this has the effect of writing incorrect row cache entries.