[CASSANDRA-9143] Fix consistency of incrementally repaired data across replicas

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-alpha1, 4.0
• Assignee: Blake Eggleston
• Reporter: Sankalp Kohli

Authors

Blake Eggleston

Reviewers

Marcus Eriksson

• Created: 09/Apr/15 00:14
• Updated: 06/May/21 07:16
• Resolved: 07/Feb/17 03:12

Description

We currently send an anticompaction request to all replicas. During this, a node will split stables and mark the appropriate ones repaired.

The problem is that this could fail on some replicas due to many reasons leading to problems in the next repair.

This is what I am suggesting to improve it.
1) Send anticompaction request to all replicas. This can be done at session level.
2) During anticompaction, stables are split but not marked repaired.
3) When we get positive ack from all replicas, coordinator will send another message called markRepaired.
4) On getting this message, replicas will mark the appropriate stables as repaired.

This will reduce the window of failure. We can also think of "hinting" markRepaired message if required.

Also the stables which are streaming can be marked as repaired like it is done now.

Issue Links

• blocks: CASSANDRA-5901 Bootstrap should also make the data consistent on the new node
• incorporates: CASSANDRA-9097 Repeated incremental nodetool repair results in failed repairs due to running anticompaction
• is duplicated by: CASSANDRA-8858 Avoid not doing anticompaction on compacted away sstables

Sub-Tasks

• Fix eclipse-warnings from CASSANDRA-9143: Resolved