[CASSANDRA-8952] Remove transient RandomAccessFile usage

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 2.2.0 beta 1
• Component/s: Legacy/Local Write-Read Paths
• Labels: Windows
• Assignee: Stefania Alborghetti
• Reporter: Joshua McKenzie

Authors

Stefania Alborghetti

Reviewers

Joshua McKenzie

• Created: 11/Mar/15 19:55
• Updated: 16/Apr/19 09:31
• Resolved: 03/Apr/15 16:41

Description

There are a few places within the code base where we use a RandomAccessFile transiently to either grab fd's or channels for other operations. This is prone to access violations on Windows (see CASSANDRA-4050 and CASSANDRA-8709) - while these usages don't appear to be causing issues at this time there's no reason to keep them. The less RandomAccessFile usage in the code-base the more stable we'll be on Windows.

SSTableReader.dropPageCache

• Used to getFD, have FileChannel version

FileUtils.truncate

• Used to get file channel for channel truncate call. Only use is in index file close so channel truncation down-only is acceptable.

MMappedSegmentedFile.createSegments

• Used to get file channel for mapping.

Keeping these in a single ticket as all three should be fairly trivial refactors.

Issue Links

• requires: CASSANDRA-8893 RandomAccessReader should share its FileChannel with all instances (via SegmentedFile)
• links to: 3.0 patch