[CASSANDRA-8750] Ensure SSTableReader.last corresponds exactly with the file end

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 2.1.5
• Assignee: Benedict Elliott Smith
• Reporter: Benedict Elliott Smith

Authors

Benedict Elliott Smith

Reviewers

Marcus Eriksson

• Created: 05/Feb/15 21:17
• Updated: 16/Apr/19 09:31
• Resolved: 04/Mar/15 16:33

Description

Following on from CASSANDRA-8744, CASSANDRA-8749 and CASSANDRA-8747, this patch attempts to make the whole opening early of compaction results more robust and with more clearly understood behaviour. The improvements of CASSANDRA-8747 permit is to easily align the last key with a summary boundary, and an index and data file end position. This patch modifies SegmentedFile to permit the provision of an explicit length, which is then provided to any readers, which enforce it, ensuring no code may accidentally see an end inconsistent with the one advertised.

Issue Links

• depends upon: CASSANDRA-8747 Make SSTableWriter.openEarly behaviour more robust
• depends upon: CASSANDRA-8749 Cleanup SegmentedFile
• is broken by: CASSANDRA-6916 Preemptive opening of compaction result
• is related to: CASSANDRA-6916 Preemptive opening of compaction result
• relates to: CASSANDRA-8744 Ensure SSTableReader.first/last are honoured universally