[CASSANDRA-8695] thrift column definition list sometimes immutable

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.1.3
• Severity: Normal
• Assignee: Chris Lockfort
• Reporter: Chris Lockfort

Authors

Chris Lockfort

Reviewers

Aleksey Yeschenko

• Created: 28/Jan/15 00:55
• Updated: 16/Apr/19 09:31
• Resolved: 28/Jan/15 15:46

Description

When the input cf_def.column_metadata is null, ColumnDefinition.fromThrift can return Collections.emptyList() (which is defined to be an immutable list)

One caller, CFMetaData.internalFromThrift , incorrectly assumes that this list will always be mutable and tries to add to this immutable list, which causes the Cassandra server to throw an exception.

It looks like this is a bug in 2.1, but not in trunk.
I can include my one-liner patch, but I'm not sure whether it is better to fix the caller (to not assume random lists you get back from a method are mutable) or the callee (to always return a mutable list).