[CASSANDRA-8691] SSTableReader.getPosition() does not correctly filter out queries that exceed its bounds

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Duplicate
• Fix Version/s: 2.1.3
• Severity: Normal
• Assignee: Unassigned
• Reporter: Benedict Elliott Smith
• Created: 27/Jan/15 12:03
• Updated: 16/Apr/19 09:31
• Resolved: 28/Jan/15 14:26

Description

This has been true for some time, but I worry about including it before 2.1 in case we depend on the brokenness somehow. In getPosition, we test:

        if (first.compareTo(key) > 0 || last.compareTo(key) < 0)
        {
            if (op == Operator.EQ && updateCacheAndStats)
                bloomFilterTracker.addFalsePositive();

            if (op.apply(1) < 0)
            {
                Tracing.trace("Check against min and max keys allows skipping sstable {}", descriptor.generation);
                return null;
            }
        }

However, op.apply(1) always returns >= 0 unless op == Operation.EQ

Issue Links

• is duplicated by: CASSANDRA-8683 Ensure early reopening has no overlap with replaced files
• relates to: CASSANDRA-8683 Ensure early reopening has no overlap with replaced files