[CASSANDRA-8496] Remove MemtablePostFlusher

• Type: Improvement
• Status: Open
• Priority: Normal
• Resolution: Unresolved
• Fix Version/s: 5.x
• Component/s: Legacy/Core
• Labels: remove-reopen
• Assignee: Unassigned
• Reporter: Benedict Elliott Smith
• Created: 17/Dec/14 11:14
• Updated: 07/Mar/23 10:54

Description

To improve clearing of the CL, prevent infinite growth, and ensure the prompt completion of tasks waiting on flush in the case of transient errors, large flushes or slow disks, in 2.1 we could eliminate the post flusher altogether.

Since we now enforce that Memtables track contiguous ranges, a relatively small change would permit Memtables to know the exact minimum as well as the currently known exact maximum. The CL could easily track the total dirty range, knowing that it must be contiguous, by using an AtomicLong instead of an AtomicInteger, and tracking both the min/max seen, not just the max. The only slight complexity will come in for tracking the clean range as this can now be non-contiguous, if there are 3 memtable flushes covering the same CL segment, and one of them completes later. To solve this we can use an interval tree since these operations are infrequent, so the extra overhead is nominal. Once the interval tree completely overlaps the dirty range, we mark the entire dirty range clean.

Issue Links

• is blocked by: CASSANDRA-11828 Commit log needs to track unflushed intervals rather than positions
• is duplicated by: CASSANDRA-10766 OOM from 22000 memtables
• is related to: CASSANDRA-7275 Errors in FlushRunnable may leave threads hung