Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      RackUnawareStrategy has tests (perhaps some of these could be made more generic); RAS does not, nor does DatacenterShardStrategy

      1. CASSANDRA-776.patch
        7 kB
        Rodrigo Peinado

        Activity

        Hide
        Rodrigo Peinado added a comment -

        I'm writing tests for RackAwareStrategy.

        Show
        Rodrigo Peinado added a comment - I'm writing tests for RackAwareStrategy.
        Hide
        Rodrigo Peinado added a comment -

        JUnit test for RackAwareStrategy. More test cases should be added, but I think this is a good start.

        Show
        Rodrigo Peinado added a comment - JUnit test for RackAwareStrategy. More test cases should be added, but I think this is a good start.
        Hide
        Rodrigo Peinado added a comment - - edited

        Is the "rack config file" location configurable?. I think it's not. It would be useful to have a custom one for DatacenterShardStrategy's unit test.

        Show
        Rodrigo Peinado added a comment - - edited Is the "rack config file" location configurable?. I think it's not. It would be useful to have a custom one for DatacenterShardStrategy's unit test.
        Hide
        Jonathan Ellis added a comment -

        committed.

        isn't the file location "anywhere on the classpath?" if not then IMO it should be. then it would be possible to create one in test/conf for instance.

        Show
        Jonathan Ellis added a comment - committed. isn't the file location "anywhere on the classpath?" if not then IMO it should be. then it would be possible to create one in test/conf for instance.
        Hide
        Hudson added a comment -

        Integrated in Cassandra #395 (See http://hudson.zones.apache.org/hudson/job/Cassandra/395/)
        add RackAwareStrategyTest. patch by Rodrigo Peinado; reviewed by jbellis for

        Show
        Hudson added a comment - Integrated in Cassandra #395 (See http://hudson.zones.apache.org/hudson/job/Cassandra/395/ ) add RackAwareStrategyTest. patch by Rodrigo Peinado; reviewed by jbellis for

          People

          • Assignee:
            Rodrigo Peinado
            Reporter:
            Jonathan Ellis
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development