Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      RackUnawareStrategy has tests (perhaps some of these could be made more generic); RAS does not, nor does DatacenterShardStrategy

      1. CASSANDRA-776.patch
        7 kB
        Rodrigo Peinado

        Activity

        Jonathan Ellis created issue -
        Hide
        Rodrigo Peinado added a comment -

        I'm writing tests for RackAwareStrategy.

        Show
        Rodrigo Peinado added a comment - I'm writing tests for RackAwareStrategy.
        Hide
        Rodrigo Peinado added a comment -

        JUnit test for RackAwareStrategy. More test cases should be added, but I think this is a good start.

        Show
        Rodrigo Peinado added a comment - JUnit test for RackAwareStrategy. More test cases should be added, but I think this is a good start.
        Rodrigo Peinado made changes -
        Field Original Value New Value
        Attachment CASSANDRA-776.patch [ 12439984 ]
        Rodrigo Peinado made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee Rodrigo Peinado [ rodrigoap ]
        Hide
        Rodrigo Peinado added a comment - - edited

        Is the "rack config file" location configurable?. I think it's not. It would be useful to have a custom one for DatacenterShardStrategy's unit test.

        Show
        Rodrigo Peinado added a comment - - edited Is the "rack config file" location configurable?. I think it's not. It would be useful to have a custom one for DatacenterShardStrategy's unit test.
        Hide
        Jonathan Ellis added a comment -

        committed.

        isn't the file location "anywhere on the classpath?" if not then IMO it should be. then it would be possible to create one in test/conf for instance.

        Show
        Jonathan Ellis added a comment - committed. isn't the file location "anywhere on the classpath?" if not then IMO it should be. then it would be possible to create one in test/conf for instance.
        Jonathan Ellis made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Cassandra #395 (See http://hudson.zones.apache.org/hudson/job/Cassandra/395/)
        add RackAwareStrategyTest. patch by Rodrigo Peinado; reviewed by jbellis for

        Show
        Hudson added a comment - Integrated in Cassandra #395 (See http://hudson.zones.apache.org/hudson/job/Cassandra/395/ ) add RackAwareStrategyTest. patch by Rodrigo Peinado; reviewed by jbellis for
        Gavin made changes -
        Workflow no-reopen-closed, patch-avail [ 12498260 ] patch-available, re-open possible [ 12752107 ]
        Gavin made changes -
        Workflow patch-available, re-open possible [ 12752107 ] reopen-resolved, no closed status, patch-avail, testing [ 12755196 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        48d 20h 41m 1 Rodrigo Peinado 27/Mar/10 23:04
        Patch Available Patch Available Resolved Resolved
        1d 17h 9m 1 Jonathan Ellis 29/Mar/10 17:13

          People

          • Assignee:
            Rodrigo Peinado
            Reporter:
            Jonathan Ellis
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development