[CASSANDRA-7765] Don't use strict endpoint selection for range movements where RF == node count

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 2.1.0
• Component/s: Legacy/Coordination
• Severity: Low
• Since Version: 2.1 beta2
• Assignee: Sam Tunnicliffe
• Reporter: Sam Tunnicliffe

Authors

Sam Tunnicliffe

Reviewers

T Jake Luciani

• Created: 13/Aug/14 20:20
• Updated: 16/Apr/19 09:31
• Resolved: 14/Aug/14 13:55

Description

Post CASSANDRA-2434, we should skip strict endpoint selection for ranges where RF == the number of nodes in the cluster otherwise we hit the following assertion in RangeStreamer.getAllRangesWithStrictSourcesFor

if (oldEndpoints.size() == strat.getReplicationFactor())
{
    oldEndpoints.removeAll(newEndpoints);
    assert oldEndpoints.size() == 1 : "Expected 1 endpoint but found " + oldEndpoints.size();
}

I think this is a fairly niche case, plus there's a workaround in the -Dcassandra.consistent.rangemovement=false option.