[CASSANDRA-737] Streaming code relies on sockets being bound to the correct address (InetAddress.anyLocalAddress() is bad)

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 0.6

Environment

Mac OS X.

• Severity: Low
• Assignee: Gary Dusbabek
• Reporter: Gary Dusbabek

Authors

Gary Dusbabek

• Created: 25/Jan/10 19:46
• Updated: 16/Apr/19 09:33
• Resolved: 25/Jan/10 21:26

Description

I came across this while testing streaming locally. The new streaming code makes use of the remote socket address supplied by the socket. This means that it will return whatever address the socket is bound to, which is not necessarily the address configured for cassandra. This confuses StreamContextManager when data comes streaming in from addresses that it doesn't recognize.

Two solutions will work.
1. bind outgoing sockets to the correct interface.
2. Include the local address in StreamContexts that get sent.

I opted for 1 since it required less code. 2 was easy enough but would have required changing the format of the message to make the source address more easily accessible (the constructor for IncomingStreamReader wants to know the source host to create the stream context at the destination).

Issue Links

• relates to: CASSANDRA-620 Add per-keyspace replication factor (possibly even replication strategy)