[CASSANDRA-7183] BackgroundActivityMonitor.readAndCompute only returns half of the values

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 2.0.9, 2.1 rc1
• Severity: Low
• Assignee: David Brosius
• Reporter: David Brosius

Authors

David Brosius

Reviewers

Jonathan Ellis

• Created: 07/May/14 05:13
• Updated: 16/Apr/19 09:31
• Resolved: 07/May/14 23:23

Description

BackgroundActivityMonitor.readAndCompute does

        long[] returned = new long[tokenizer.countTokens()];
        for (int i = 0; i < tokenizer.countTokens(); i++)
            returned[i] = Long.parseLong(tokenizer.nextToken());

which is not only inefficient as it counts tokens each time thru the loop, it's wrong in that only the first half of the values are populated in the array, as each time thru the loop the number of tokens goes down by 1, since you've consumed one.

switch the loop to

 for (int i = 0; i < returned.length; i++)