[CASSANDRA-7089] Some problems with typed ByteBuffer comparisons?

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 2.1 beta2
• Severity: Low
• Assignee: Sylvain Lebresne
• Reporter: Benedict Elliott Smith

Authors

Sylvain Lebresne

Reviewers

Benedict Elliott Smith

• Created: 24/Apr/14 22:41
• Updated: 16/Apr/19 09:31
• Resolved: 25/Apr/14 10:22

Description

ColumnIdentifier.compareTo() appears subtly broken: it looks to me that we should be using ByteBufferUtil.compareUnsigned() instead of bytes.compareTo(), since they are meant to be UTF8Type. I think it would be nice to drop this compareTo method entirely, as it's only used by CFMetaData.regularColumnComparator and it seems possible to misuse accidentally at a later date since it only works for CQL columns, but a ColumnIdentifier is used for thrift columns as well.

There's a related problem with CellName.isPrefixOf, where we are using equals() instead of type.compareTo() == 0, which could break anyone misusing our old friend Boolean as a clustering column.